Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add CODEOWNERS.md and README.md to apm-python team #9889

Merged
merged 3 commits into from
Jul 22, 2024
Merged

chore: add CODEOWNERS.md and README.md to apm-python team #9889

merged 3 commits into from
Jul 22, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Jul 22, 2024 •
edited by brettlangdon
Loading

These two .md files should be approvable by anyone in apm-python, not just core.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda requested review from a team as code owners July 22, 2024 14:39
@erikayasuda erikayasuda enabled auto-merge (squash) July 22, 2024 14:40
@github-actions GitHub Actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 22, 2024
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: erikayasuda/release-notes-codeowner
Commit report: 9a5bf6c
Test service: dd-trace-py

❌ 1 Failed (0 Known Flaky), 124798 Passed, 52096 Skipped, 4h 13m 32.88s Total duration (5h 22m 23.55s time saved)

❌ Failed Tests (1)

  • test_propagation_memory_check[taintsource1-taintsource20] - test_iast_mem_check.py - Details

    Expand for error 
     assert 28 == 27
  +  where 27 = num_objects_tainted()

@erikayasuda erikayasuda merged commit 4c854a8 into main Jul 22, 2024
54 checks passed
@erikayasuda erikayasuda deleted the erikayasuda/release-notes-codeowner branch July 22, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikayasuda @brettlangdon